fix: handle MSVC warning C4866: compiler may not enforce left-to-right evaluation order#5641
Merged
Merged
Conversation
2efbea6 to
2268f7e
Compare
…t evaluation order
2268f7e to
e29b35b
Compare
henryiii
approved these changes
May 7, 2025
b-pass
pushed a commit
to b-pass/pybind11
that referenced
this pull request
May 9, 2025
…t evaluation order (pybind#5641)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Original error: https://github.com/metaopt/optree/actions/runs/14840166206/job/41660965730?pr=214#step:10:981
Same background (ChatGPT): https://chatgpt.com/share/681d0822-ce30-8008-89a9-74568143f1ee
Copy of error (so search engines pick this up in the future):
Suggested changelog entry: